Am Samstag, 18. Juli 2009 01:21:34 schrieb Rory Filer: > > -----Original Message----- > > From: Oliver Neukum [mailto:oliver@xxxxxxxxxx] > > Sent: Friday, July 17, 2009 7:12 AM > > > > > The sierra.c driver is sufficient to interact over USB interfaces for > > > all of our modem products, so one driver fits all. However many of our > > > modems today do not support Selective Suspend – they may crash or > > > behave unpredictably when suspended - but they may eventually support > > > it. > > > > In this case you should add those devices to the quirk list with > > the RESET_RESUME quirk. As you currently do not implement > > a handler for reset_resume, usbcore will leave those devices alone. > > Looks like this suggestion would work as discussed, but at the cost of > editing/compiling/installing. For most of the audience reading this it's > not a big deal, but our modems are in the hands of consumers. Why on earth > would you expect an end-user to have to patch and install a driver just so > they can turn on a feature? This patch we are submitting already does this > via our so-called redundant module attribute. Perhaps also not the most > elegant solution, but easier than patching/building/installing. If your devices can crash when suspended, adding them to the quirks table isn't optional, it is required if probe() is to function all the time. Otherwise your device may be suspended and thus crashed before your driver is loaded. Does this mean that you don't know or cannot tell by product id/version which of your devices can be suspended? Generally we of course do not expect a recompilation to support autosuspend. Udev is supposed to switch on autosuspend via the sysfs attribute "level", without any kernel modification. For this to work it is important that the generic attribute be always used, as it is guaranteed to be present all the time and for all devices. Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
