Re: [PATCH v2 1/8] usb: cdns3: gadget: using correct sg operations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 24, 2020 at 5:35 PM Peter Chen <peter.chen@xxxxxxx> wrote:
>
>
> >
> > Peter Chen <peter.chen@xxxxxxx> writes:
> >
> > > It needs to use request->num_mapped_sgs to indicate mapped sg number,
> > > the request->num_sgs is the sg number before the mapping. These two
> > > entries have different values for the platforms which iommu or swiotlb
> > > is used. Besides, it needs to use correct sg APIs for mapped sg list
> > > for TRB assignment.
> > >
> > > Signed-off-by: Peter Chen <peter.chen@xxxxxxx>
> >
> > fails to apply to my testing/next
> >
> > checking file drivers/usb/cdns3/gadget.c Hunk #1 succeeded at 1099 (offset 1
> > line).
> > Hunk #2 succeeded at 1165 (offset 1 line).
> > Hunk #3 FAILED at 1176.
> > Hunk #4 succeeded at 1221 with fuzz 2 (offset 1 line).
> > 1 out of 4 hunks FAILED
> >
>
> It could work now, I think the possible reason is you have already applied other cdns3 patches during
> these two hours. My git log likes below:
>
> ca71afbe0c52 (HEAD -> felipe_testing_next) usb: cdns3: gadget: enlarge the TRB ring length
> 50599e28f626 usb: cdns3: gadget: sg_support is only for DEV_VER_V2 or above
> ed1e5b0fe5b2 usb: cdns3: gadget: need to handle sg case for workaround 2 case
> 95c952507262 usb: cdns3: gadget: handle sg list use case at completion correctly
> 9d45b67cf0c3 usb: cdns3: gadget: add CHAIN and ISP bit for sg list use case
> 28e5fd2c3fae usb: cdns3: gadget: calculate TDL correctly
> f57692f1a9a4 usb: cdns3: gadget: improve the dump TRB operation at cdns3_ep_run_transfer
> 5f94832916b5 usb: cdns3: gadget: using correct sg operations
> bed7c9e9a5aa (felipe/testing/next) usb: dwc3: gadget: Rename misleading function names
> 3d7ce113c2d0 usb: dwc3: gadget: Refactor preparing last TRBs
> 43365b1e90af usb: dwc3: gadget: Set IOC if not enough for extra TRBs
> ea52ca3fdefb usb: dwc3: gadget: Check for number of TRBs prepared
> e6ccecf58b1b usb: dwc3: gadget: Return the number of prepared TRBs
>
> Thanks,
> Peter

Hi Felipe,

I have still not seen these patches on your tree, would you please
help to queue them for v5.10-rc1?

Peter



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux