On Tue, Sep 22, 2020 at 9:04 AM Rob Herring <robh@xxxxxxxxxx> wrote: > > On Mon, Sep 21, 2020 at 12:55:49PM -0700, Badhri Jagan Sridharan wrote: > > This change adds frs-typec-current which allows setting the initial current > > capability of the new source when vSafe5V is applied during PD3.0 > > sink Fast Role Swap. > > > > Signed-off-by: Badhri Jagan Sridharan <badhri@xxxxxxxxxx> > > --- > > Changes since v1: > > - Changing patch version to v6 to fix version number confusion. > > > > Changes since v6: > > - Removed the redundant usb-connector.txt that I created by mistake. > > - Moved to yaml. > > > > Changes since v7: > > - Rebase > > --- > > .../devicetree/bindings/connector/usb-connector.yaml | 8 ++++++++ > > include/dt-bindings/usb/pd.h | 10 ++++++++++ > > 2 files changed, 18 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/connector/usb-connector.yaml b/Documentation/devicetree/bindings/connector/usb-connector.yaml > > index 9bd52e63c935..1ca8e6a337e5 100644 > > --- a/Documentation/devicetree/bindings/connector/usb-connector.yaml > > +++ b/Documentation/devicetree/bindings/connector/usb-connector.yaml > > @@ -142,6 +142,14 @@ properties: > > required: > > - port@0 > > > > + frs-typec-current: > > + description: Initial current capability of the new source when vSafe5V > > + is applied during PD3.0 Fast Role Swap. "Table 6-14 Fixed Supply PDO - Sink" > > + of "USB Power Delivery Specification Revision 3.0, Version 1.2" provides the > > + different power levels and "6.4.1.3.1.6 Fast Role Swap USB Type-C Current" > > + provides a detailed description of the field. > > + $ref: /schemas/types.yaml#/definitions/uint32 > > Looks the same/similar to this[1]. Please come up with a common > approach to cover both. > > Rob > > https://lore.kernel.org/linux-arm-kernel/20200902075707.9052-2-amelie.delaunay@xxxxxx/ Hi Rob, The values will not be an exact overlap as it's a different functionality. [1] introduces a property for defining the power operation mode for the type-c connector. However [2] introduces a property to define the new-source's current capability during Fast role swap operation. However, I modified [2] to use string based enums to follow the pattern in [1] in v9 version of the patch which I just sent out. 1. https://lore.kernel.org/linux-arm-kernel/20200902075707.9052-2-amelie.delaunay@xxxxxx/ 2. https://lore.kernel.org/patchwork/patch/1309792/ Thanks, Badhri
