Re: [PATCH] usb: bdc: Remove duplicate error message in bdc_probe()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




在 2020/9/28 14:49, Chunfeng Yun 写道:
On Sun, 2020-09-27 at 21:42 +0800, Tang Bin wrote:
In this function, we don't need dev_err() message because
when something goes wrong, devm_platform_ioremap_resource()
can print an error message itself, so remove the redundant
one.

Signed-off-by: Zhang Shengju <zhangshengju@xxxxxxxxxxxxxxxxxxxx>
Signed-off-by: Tang Bin <tangbin@xxxxxxxxxxxxxxxxxxxx>
---
  drivers/usb/gadget/udc/bdc/bdc_core.c | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/usb/gadget/udc/bdc/bdc_core.c b/drivers/usb/gadget/udc/bdc/bdc_core.c
index 02a3a7746..9454f179e 100644
--- a/drivers/usb/gadget/udc/bdc/bdc_core.c
+++ b/drivers/usb/gadget/udc/bdc/bdc_core.c
@@ -508,10 +508,8 @@ static int bdc_probe(struct platform_device *pdev)
  	bdc->clk = clk;
bdc->regs = devm_platform_ioremap_resource(pdev, 0);
-	if (IS_ERR(bdc->regs)) {
-		dev_err(dev, "ioremap error\n");
+	if (IS_ERR(bdc->regs))
  		return -ENOMEM;
-	}
  	irq = platform_get_irq(pdev, 0);
  	if (irq < 0)
  		return irq;
Cc bdc's maintainer:  Florian Fainelli <f.fainelli@xxxxxxxxx>

Got it, thanks.

Tang Bin








[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux