On Friday 17 July 2009, Sergei Shtylyov wrote: > This function uses wrong bit mask to prevent clearing RXCSR status > bits when halting an endpoint -- which results in clearing SentStall > and RxPktRdy bits (that the code actually tries to avoid); must be > a result of cut-and-paste... > > Signed-off-by: Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx> Acked-by: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx> ... best fixed for 2.6.31-rc, I think > > --- > The patch is atop of the current Linus' tree... > > drivers/usb/musb/musb_gadget_ep0.c | 2 +- > 1 files changed, 1 insertion(+), 1 deletion(-) > > Index: linux-2.6/drivers/usb/musb/musb_gadget_ep0.c > =================================================================== > --- linux-2.6.orig/drivers/usb/musb/musb_gadget_ep0.c > +++ linux-2.6/drivers/usb/musb/musb_gadget_ep0.c > @@ -407,7 +407,7 @@ stall: > csr |= MUSB_RXCSR_P_SENDSTALL > | MUSB_RXCSR_FLUSHFIFO > | MUSB_RXCSR_CLRDATATOG > - | MUSB_TXCSR_P_WZC_BITS; > + | MUSB_RXCSR_P_WZC_BITS; > musb_writew(regs, MUSB_RXCSR, > csr); > } > > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
