Re: [PATCH 002/002] USB: serial: sierra driver autosuspend support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 17, 2009 at 09:58:06AM -0400, Alan Stern wrote:
> On Thu, 16 Jul 2009, Greg KH wrote:
> 
> > > As far as whether a driver-wide or a device-wide parameter is the way to go,
> > > I think you could argue it either way. But since implementing it on a
> > > per-device basis can be configured to work the same as the driver-wide case,
> > > we are looking at ways to do this. One approach is to add a  device attribute
> > > with read/write capabilities that will have specific value based on the device.
> > > Weâ??d be interested in getting your opinion as to whether this approach may
> > > meet with further opposition. 
> > 
> > Yes, per-device attribute would work, but please follow the standard api
> > for this (I think there is one for USB devices, can't recall it at the
> > moment, sorry.)
> 
> We already have a per-device sysfs attribute for autosuspend
> management; there's no point in adding a new one to do the same thing.

Ah, that's what I was thinking of.

Great, no need to add anything, just modify the driver a bit to only
do this for devices that are known to work properly with it :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux