Re: [PATCH v2 6/7] usb: dwc3: gadget: Rename misleading function names

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thinh Nguyen <Thinh.Nguyen@xxxxxxxxxxxx> writes:

> Hi Felipe,
>
> Felipe Balbi wrote:
>> Thinh Nguyen <Thinh.Nguyen@xxxxxxxxxxxx> writes:
>>
>>> The functions dwc3_prepare_one_trb_sg and dwc3_prepare_one_trb_linear
>>> are not necessarily preparing "one" TRB, it can prepare multiple TRBs.
>>> Rename these functions as follow:
>>>
>>> dwc3_prepare_one_trb_sg -> dwc3_prepare_trbs_sg
>>> dwc3_prepare_one_trb_linear -> dwc3_prepare_trbs_linear
>>>
>>> Signed-off-by: Thinh Nguyen <thinhn@xxxxxxxxxxxx>
>> Tried to apply on top of -rc6:
>>
>> checking file drivers/usb/dwc3/gadget.c
>> Hunk #1 FAILED at 1161.
>> Hunk #2 FAILED at 1231.
>> Hunk #3 FAILED at 1266.
>> Hunk #4 FAILED at 1294.
>> 4 out of 4 hunks FAILED
>>
>
> I'll rebase send out a new series with a bunch of fixes.
>
> Btw, the patches you just merged are not the latest:
> usb: dwc3: gadget: Resume pending requests after CLEAR_STALL
> usb: dwc3: gadget: END_TRANSFER before CLEAR_STALL command
>
> The latest are on your "testing/fixes" branch

Argh, nice catch. I'll fix it shortly.

-- 
balbi

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux