On Wed, Sep 23, 2020 at 7:51 PM Oliver Neukum <oneukum@xxxxxxxx> wrote: > > Am Mittwoch, den 23.09.2020, 19:36 +0530 schrieb Himadri Pandya: > > On Wed, Sep 23, 2020 at 3:52 PM Oliver Neukum <oneukum@xxxxxxxx> wrote: > > > > > > Am Mittwoch, den 23.09.2020, 14:35 +0530 schrieb Himadri Pandya: > > > > GFP_NOIO is used here for a reason. You need to use this helper > > > while in contexts of error recovery and runtime PM. > > > > > > > Understood. Apologies for proposing such a stupid change. > > Hi, > > sorry if you concluded that the patch was stupid. That was not my > intent. It was the best the API allowed for. If an API makes it > easy to make a mistake, the problem is with the API, not the developer. > > Regards > Oliver > I meant that it was stupid to change it without properly understanding the significance of GFP_NOIO in this context. So now, do we re-write the wrapper functions with flag passed as a parameter? Regards, Himadri
