On Tue, 22 Sep 2020 at 18:45, Jun Li <jun.li@xxxxxxx> wrote: > > > > > -----Original Message----- > > From: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > > Sent: Tuesday, September 22, 2020 10:33 PM > > To: Jun Li <jun.li@xxxxxxx> > > Cc: robh+dt@xxxxxxxxxx; shawnguo@xxxxxxxxxx; balbi@xxxxxxxxxx; > > mathias.nyman@xxxxxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx; > > s.hauer@xxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx; festevam@xxxxxxxxx; > > dl-linux-imx <linux-imx@xxxxxxx>; Anson Huang <anson.huang@xxxxxxx>; > > Aisheng Dong <aisheng.dong@xxxxxxx>; Peng Fan <peng.fan@xxxxxxx>; Andy Duan > > <fugang.duan@xxxxxxx>; Joakim Zhang <qiangqing.zhang@xxxxxxx>; Horia > > Geanta <horia.geanta@xxxxxxx>; linux-usb@xxxxxxxxxxxxxxx; > > devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > > Subject: Re: [PATCH v3 3/6] dt-bindings: usb: dwc3-imx8mp: add imx8mp dwc3 > > glue bindings > > > > On Tue, 22 Sep 2020 at 12:56, Li Jun <jun.li@xxxxxxx> wrote: > > > > > > NXP imx8mp integrates 2 dwc3 3.30b IP and add some wakeup logic to > > > support low power mode, the glue layer is for this wakeup > > > functionality, which has a separated interrupt, can support wakeup > > > from U3 and connect events for host, and vbus wakeup for device. > > > > > > Signed-off-by: Li Jun <jun.li@xxxxxxx> > > > --- > > > .../devicetree/bindings/usb/fsl,imx8mp-dwc3.yaml | 99 > > ++++++++++++++++++++++ > > > 1 file changed, 99 insertions(+) > > > > > > diff --git > > > a/Documentation/devicetree/bindings/usb/fsl,imx8mp-dwc3.yaml > > > b/Documentation/devicetree/bindings/usb/fsl,imx8mp-dwc3.yaml > > > new file mode 100644 > > > index 0000000..a5d5566 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/usb/fsl,imx8mp-dwc3.yaml > > > @@ -0,0 +1,99 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) # Copyright > > > +(c) 2020 NXP %YAML 1.2 > > > +--- > > > +$id: > > > > > +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi > > > > > +cetree.org%2Fschemas%2Fusb%2Ffsl%2Cimx8mp-dwc3.yaml%23&data=02%7C > > > > > +01%7Cjun.li%40nxp.com%7Ceaedeb64ec15472183d108d85f046841%7C686ea1d3bc > > > > > +2b4c6fa92cd99c5c301635%7C0%7C0%7C637363819819667936&sdata=IvFQ8l0 > > > +7VXUMbG8riyITSTZb1P50oIXs%2BkAV%2FeX8ntk%3D&reserved=0 > > > +$schema: > > > > > +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi > > > > > +cetree.org%2Fmeta-schemas%2Fcore.yaml%23&data=02%7C01%7Cjun.li%40 > > > > > +nxp.com%7Ceaedeb64ec15472183d108d85f046841%7C686ea1d3bc2b4c6fa92cd99c > > > > > +5c301635%7C0%7C0%7C637363819819677934&sdata=H3%2BcwgiLKBynHv4N%2F > > > +dogBi3SwaizVHmqieJXVrErv0I%3D&reserved=0 > > > + > > > +title: NXP iMX8MP Soc USB Controller > > > + > > > +maintainers: > > > + - Li Jun <jun.li@xxxxxxx> > > > + > > > +properties: > > > + compatible: > > > + items: > > > > Items are not necessary > > > > > > > + - const: fsl,imx8mp-dwc3 > > > + > > > + reg: > > > + maxItems: 1 > > > + description: Address and length of the register set for the wrapper > > of > > > + dwc3 core on the SOC. > > > + > > > + "#address-cells": > > > + enum: [ 1, 2 ] > > > + > > > + "#size-cells": > > > + enum: [ 1, 2 ] > > > + > > > + ranges: true > > > + > > > + interrupts: > > > + maxItems: 1 > > > + description: The interrupt that is asserted when a wakeup event is > > > + received. > > > + > > > + clocks: > > > + description: > > > + A list of phandle and clock-specifier pairs for the clocks > > > + listed in clock-names. > > > + items: > > > + - description: system hsio root clock. > > > + - description: suspend clock, used for usb wakeup logic. > > > + > > > + clock-names: > > > + items: > > > + - const: hsio > > > + - const: suspend > > > + > > > +# Required child node: > > > + > > > +patternProperties: > > > + "^dwc3@[0-9a-f]+$": > > > + type: object > > > + description: > > > + A child node must exist to represent the core DWC3 IP block > > > + The content of the node is defined in dwc3.txt. > > > + > > > +required: > > > + - compatible > > > + - reg > > > + - "#address-cells" > > > + - "#size-cells" > > > + - ranges > > > + - clocks > > > + - clock-names > > > + - interrupts > > > + > > > +additionalProperties: false > > > > Do you actually validate your DTS changes with this schema? They do not look > > like passing the validation... > > I did run dt_binding_check, maybe I missed some errors as there are always some other > failures, I will re-run to double check. dt_binding_check is good for the binding and example. Except this you need to run dtbs_check so your new DTS will be checked. In this case it points to missing properties in the bindings. Best regards, Krzysztof
