On Mon, Sep 21, 2020 at 10:42:16AM -0700, Ajay Gupta wrote: > From: Ajay Gupta <ajayg@xxxxxxxxxx> > > Timeout error may be seen due to missing USB Type-C UCSI controller > on some NVIDIA GPU card. Currently we don't have a correct way to > identify these cards. No unique id anywhere??? That feels like someone really messed up :( > > Tools like Plymouth (splashscreen) doesn't like dev_err so > changing timeout status log to dev_info. > > Bug information: > https://bugzilla.kernel.org/show_bug.cgi?id=206653 > > Signed-off-by: Ajay Gupta <ajayg@xxxxxxxxxx> > --- > drivers/usb/typec/ucsi/ucsi_ccg.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/usb/typec/ucsi/ucsi_ccg.c b/drivers/usb/typec/ucsi/ucsi_ccg.c > index bff96d64dddf..d69432df866e 100644 > --- a/drivers/usb/typec/ucsi/ucsi_ccg.c > +++ b/drivers/usb/typec/ucsi/ucsi_ccg.c > @@ -252,7 +252,7 @@ static int ccg_read(struct ucsi_ccg *uc, u16 rab, u8 *data, u32 len) > put_unaligned_le16(rab, buf); > status = i2c_transfer(client->adapter, msgs, ARRAY_SIZE(msgs)); > if (status < 0) { > - dev_err(uc->dev, "i2c_transfer failed %d\n", status); > + dev_info(uc->dev, "i2c_transfer failed %d\n", status); It's an error, leave it an error. If it's not an error, don't log it. Or better yet, fix the hardware :) thanks, greg k-h
