On Wed, Jul 15, 2009 at 03:51:12PM -0500, Jason Wessel wrote: > Greg KH wrote: > > On Mon, Jun 22, 2009 at 11:32:22AM -0500, Jason Wessel wrote: > > > >> There is no need to have external function calls for the sysrq > >> functions. The compiler can inline the sysrq calls such that they are > >> entirely a NOP if CONFIG_MAGIC_SYSRQ is not set. > >> > >> Signed-off-by: Jason Wessel <jason.wessel@xxxxxxxxxxxxx> > >> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx> > >> > > > > This now doesn't seem needed in Linus's tree due to Alan's changes, > > right? > > > > I've dropped it, if it's still needed, please redo and send it to me. > > > > > > I re-spun the patch. It is not necessarily "required", but I think it > is a good practice to optimize the usb serial code in the same manner as > the rs232 uart driver code, and of course cutting out two extra kernel > exports and a level of extra function calls. > > If you would prefer to keep it the way it is, let me know, because I > have a change set that stacks on top of this, for processing the sysrq > with a tasklet. That's fine, I'll take your patch. Care to resend it with your other stuff at the same time? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
