On Wed, Sep 16, 2020 at 03:33:25PM +0200, Andrey Konovalov wrote:
> Hi Bastien, Greg, Alan,
>
> Looks like commit adb6e6ac20ee ("USB: Also match device drivers using
> the ->match vfunc") broke the USB driver ID matching process. This, in
> turn, led to a complete breakage of the USB fuzzing instance.
>
> This is how an attempt to connect a USB device looks now:
>
> [ 39.781642][ T12] usb 1-1: new high-speed USB device number 2
> using dummy_hcd
> [ 40.299955][ T12] usb 1-1: New USB device found, idVendor=0cf3,
> idProduct=9271, bcdDevice= 1.08
> [ 40.303072][ T12] usb 1-1: New USB device strings: Mfr=1,
> Product=2, SerialNumber=3
> [ 40.305678][ T12] usb 1-1: Product: syz
> [ 40.307041][ T12] usb 1-1: Manufacturer: syz
> [ 40.308556][ T12] usb 1-1: SerialNumber: syz
> [ 40.314825][ T12] usbip-host 1-1: 1-1 is not in match_busid table... skip!
> [ 42.500114][ T51] usb 1-1: USB disconnect, device number 2
>
> It seems that when going through the list of registered IDs the code
> tries to match against USB/IP and succeeds as usbip_match() always
> returns true.
>
> I'm not sure what's the best fix for this is.
I thought that is what the patch from Bastien was supposed to fix?
If it didn't, we can revert it.
thanks,
greg k-h
