On Wed, Sep 9, 2020 at 11:34 PM Lars Melin <larsm17@xxxxxxxxx> wrote: > > On 9/10/2020 10:02, Oliver Neukum wrote: > > Am Mittwoch, den 09.09.2020, 13:34 -0600 schrieb James Hilliard: > >> This patch detects and reverses the effects of the malicious FTDI > >> Windows driver version 2.12.00(FTDIgate). > > > > Hi, > > > > this raises questions. > > Should we do this unconditionally without asking? > > Does this belong into kernel space? > > > > My answer to both of those question is a strong NO. > > The patch author tries to justify the patch with egoistical arguments > (easier for him and his customers) without thinking of all other users > of memory constrained embedded hardware that doesn't need the patch code > but have to carry it. If that's a concern it would not be difficult to add a kconfig option to allow disabling it. > > The bricked PID is btw already supported by the linux ftdi driver so > there is no functionality gain in the patch. By the kernel driver sure, but userspace is where things get messed up without something like this. > > br > Lars > > >
