On Tue, 14 Jul 2009, Alek Du wrote:
> Hi Alan,
>
> Basically, this is not something new my patch introduced, I just follow the way that how USBMODE defined & used.
> If I change the definition, I need to modify USBMODE too, otherwise the ehci_def.h seems odd. If we must change
> this, it need another patch that fix all the registers that use this way.
>
>
> /* put TDI/ARC silicon into EHCI mode */
> static void tdi_reset (struct ehci_hcd *ehci)
> {
> u32 __iomem *reg_ptr;
> u32 tmp;
>
> reg_ptr = (u32 __iomem *)(((u8 __iomem *)ehci->regs) + USBMODE);
Okay. This can be changed for all the usages later on. Encapsulation
in a macro may prove even better than changing the offset definitions.
Alan Stern
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
