Re: [PATCH 7/8] usb: cdns3: gadget: sg_support is only for DEV_VER_V2 or above

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Peter Chen <peter.chen@xxxxxxx> writes:

> The scatter buffer list support earlier than DEV_VER_V2 is not
> good enough, software can't know well about short transfer for it.
>
> Cc: Pawel Laszczak <pawell@xxxxxxxxxxx>
> Signed-off-by: Peter Chen <peter.chen@xxxxxxx>
> ---
>  drivers/usb/cdns3/gadget.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/cdns3/gadget.c b/drivers/usb/cdns3/gadget.c
> index 1fd36bc5c6db..82dc362550bf 100644
> --- a/drivers/usb/cdns3/gadget.c
> +++ b/drivers/usb/cdns3/gadget.c
> @@ -3161,7 +3161,6 @@ static int cdns3_gadget_start(struct cdns3 *cdns)
>  	priv_dev->gadget.speed = USB_SPEED_UNKNOWN;
>  	priv_dev->gadget.ops = &cdns3_gadget_ops;
>  	priv_dev->gadget.name = "usb-ss-gadget";
> -	priv_dev->gadget.sg_supported = 1;
>  	priv_dev->gadget.quirk_avoids_skb_reserve = 1;
>  	priv_dev->gadget.irq = cdns->dev_irq;
>  
> @@ -3200,6 +3199,8 @@ static int cdns3_gadget_start(struct cdns3 *cdns)
>  		readl(&priv_dev->regs->usb_cap2));
>  
>  	priv_dev->dev_ver = GET_DEV_BASE_VERSION(priv_dev->dev_ver);
> +	if (priv_dev->dev_ver >= DEV_VER_V2)
> +		priv_dev->gadget.sg_supported = 1;

is this a bug fix?

-- 
balbi

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux