Re: [PATCH] thunderbolt: Retry DROM read once if parsing fails

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 07, 2020 at 01:21:51PM +0200, Lukas Wunner wrote:
> On Mon, Sep 07, 2020 at 02:03:40PM +0300, Mika Westerberg wrote:
> > Kai-Heng reported that sometimes DROM parsing of ASUS PA27AC Thunderbolt 3
> > monitor fails. This makes the driver to fail to add the device so only
> > DisplayPort tunneling is functional.
> 
> Maybe the DROM is contained in an external EEPROM attached via slow
> SPI or i2c and cannot be read in time before a response on the control
> channel is due?  Does it help to always delay 100 ms before performing
> the DROM read with this display?  Perhaps a quirk specific for this
> display is more appropriate than a change which affects all devices?
> Because this way of working around problems is difficult to maintain
> long term.

It helps to always wait the 100ms IIRC but I'm not sure we want to do
that for every device. Also I'm not a fan of maintaining a list of
quirks if we have the possibility to have more "general" solution to the
issue (like what we do here, retry once).



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux