On Fri, Sep 04, 2020 at 06:38:21PM +0800, PengHao wrote: > Hi, Hans > > Thanks for the review. And sorry for I'm not really familiar with > mailing list, so didn't reply early. > > Actually the reason why I submit this patch, is the vendor ask we do > this, they do not want enable touchpad wakeup. That says _what_ they want to do, but we need to know _why_ this is the case. What is wrong with the existing touchpad wakeup functionality that is broken on this device? Why does this quirk have to be added, what goes wrong if it is not added? Please put that information in the changelog text. thanks, greg k-h