Re: [PATCH v3 1/2] usb-storage: fix sdev->host->dma_dev

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hmm, actually the older versions were pretty much an entirely
different approach/patch (not involving fixing the dma_dev at all).
Should I just resend without the "v3"?

On Thu, 3 Sep 2020 at 16:19, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Thu, Sep 03, 2020 at 03:56:38PM +0800, Tom Yan wrote:
> > Use scsi_add_host_with_dma() instead of scsi_add_host() in usb.c and uas.c.
> >
> > When the scsi request queue is initialized/allocated, hw_max_sectors is clamped
> > to the dma max mapping size. Therefore, the correct device that should be used
> > for the clamping needs to be set.
> >
> > The same clamping is still needed in the USB drivers as hw_max_sectors could be
> > changed there. The original clamping would be invalidated in such cases.
> >
> > Signed-off-by: Tom Yan <tom.ty89@xxxxxxxxx>
> > ---
> >  drivers/usb/storage/scsiglue.c |  2 +-
> >  drivers/usb/storage/uas.c      | 17 +++++++++++------
> >  drivers/usb/storage/usb.c      |  5 +++--
> >  3 files changed, 15 insertions(+), 9 deletions(-)
>
> What changed from the previous version?  Always include that below the
> --- line as is documented to do so.
>
> Please fix up and resend.
>
> thanks,
>
> greg k-h



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux