Re: [PATCH] less- and greater than confusion

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thanks for the patch!  I found this bug last week, and a fix for it is
sitting in my git tree.  I'm waiting on another patch from someone else
that touches the device contexts before I send the bug fix out.

Sarah Sharp

On Mon, Jul 13, 2009 at 12:23:47AM +0200, Roel Kluin wrote:
> Without this change the loops won't start
> 
> Signed-off-by: Roel Kluin <roel.kluin@xxxxxxxxx>
> ---
> diff --git a/drivers/usb/host/xhci-dbg.c b/drivers/usb/host/xhci-dbg.c
> index 2501c57..56032f2 100644
> --- a/drivers/usb/host/xhci-dbg.c
> +++ b/drivers/usb/host/xhci-dbg.c
> @@ -419,7 +419,7 @@ void xhci_dbg_ctx(struct xhci_hcd *xhci, struct xhci_device_control *ctx, dma_ad
>  			&ctx->add_flags, (unsigned long long)dma,
>  			ctx->add_flags);
>  	dma += field_size;
> -	for (i = 0; i > 6; ++i) {
> +	for (i = 0; i < 6; ++i) {
>  		xhci_dbg(xhci, "@%p (virt) @%08llx (dma) %#08x - rsvd[%d]\n",
>  				&ctx->rsvd[i], (unsigned long long)dma,
>  				ctx->rsvd[i], i);
> @@ -443,7 +443,7 @@ void xhci_dbg_ctx(struct xhci_hcd *xhci, struct xhci_device_control *ctx, dma_ad
>  			&ctx->slot.dev_state,
>  			(unsigned long long)dma, ctx->slot.dev_state);
>  	dma += field_size;
> -	for (i = 0; i > 4; ++i) {
> +	for (i = 0; i < 4; ++i) {
>  		xhci_dbg(xhci, "@%p (virt) @%08llx (dma) %#08x - rsvd[%d]\n",
>  				&ctx->slot.reserved[i], (unsigned long long)dma,
>  				ctx->slot.reserved[i], i);
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux