Hey greg, On Sat, 11 Jul 2009 06:09:16 +0800 Greg KH <greg@xxxxxxxxx> wrote: > On Fri, Jun 26, 2009 at 04:55:11PM +0800, Alek Du wrote: > > From 34626a36a0b0ca7021f96623dc0abadb9bb61d36 Mon Sep 17 00:00:00 > > 2001 From: Alek Du <alek.du@xxxxxxxxx> > > Date: Fri, 26 Jun 2009 16:01:23 +0800 > > Subject: [PATCH] EHCI: split ehci_qh - header file changes > > > > Modified ehci.h, added ehci_qh_hw to hold hw part, also prepared a > > "HW" macro for sw->hw conversion. > > This patch causes the build to break :( This is the 1/4 patch, this only changes header file, of couse it will break the build if you do not apply the reset [*/4] patches. > > You need to create patches such that nothing breaks at every step > along the way, not like this. I did this to help easy review, David said the original patch is just too big to review. So I made them in 4 patches. > > Care to respin your two series? > > > +/* get ehci_qh_hw from ehci_qh */ > > +#define HW(x) ((x)->hw) > > That's a pretty generic define, why do you need it? > Ok, that could be removed. > thanks, > > greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
