On Sat, Aug 29, 2020 at 08:30:42PM +0300, Sergey Shtylyov wrote:
> Commit 8bb54ab573ec ("usbcore: add usb_device_driver definition") added
> the printk() calls with the error massages spoilt due to the stray tabs
> in the middle. Remove these tabs and convert printk() calls to pr_err()
> for consistency with the other code, while at it.
>
> Fixes: 8bb54ab573ec ("usbcore: add usb_device_driver definition")
> Signed-off-by: Sergey Shtylyov <s.shtylyov@xxxxxxxxxxxx>
>
> ---
> The patch is against the 'usb-linus' branch of Greg KH's 'usb.git' repo...
>
> drivers/usb/core/driver.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> Index: usb/drivers/usb/core/driver.c
> ===================================================================
> --- usb.orig/drivers/usb/core/driver.c
> +++ usb/drivers/usb/core/driver.c
> @@ -973,8 +973,7 @@ int usb_register_device_driver(struct us
> bus_for_each_dev(&usb_bus_type, NULL, new_udriver,
> __usb_bus_reprobe_drivers);
> } else {
> - printk(KERN_ERR "%s: error %d registering device "
> - " driver %s\n",
> + pr_err("%s: error %d registering device driver %s\n",
> usbcore_name, retval, new_udriver->name);
> }
>
> @@ -1050,9 +1049,8 @@ out:
> out_newid:
> driver_unregister(&new_driver->drvwrap.driver);
>
> - printk(KERN_ERR "%s: error %d registering interface "
> - " driver %s\n",
> - usbcore_name, retval, new_driver->name);
> + pr_err("%s: error %d registering interface driver %s\n",
> + usbcore_name, retval, new_driver->name);
> goto out;
> }
> EXPORT_SYMBOL_GPL(usb_register_driver);
Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
