On Thu, 2020-08-27 at 16:48 +0200, Amjad Ouled-Ameur wrote: > This reverts commit 7a410953d1fb4dbe91ffcfdee9cbbf889d19b0d7. > > This commit breaks USB on meson-gxl-s905x-libretech-cc. Reverting > the change solves the issue. > > In fact, according to the reset framework code, consumers must not use > reset_control_(de)assert() on shared reset lines when reset_control_reset > has been used, and vice-versa. > > Moreover, with this commit, usb is not guaranted to be reset since the > reset is likely to be initially deasserted. > > Reverting the commit will bring back the suspend warning mentioned in the > commit description. Nevertheless, a warning is much less critical than > breaking dwc3-meson-g12a USB completely. We will address the warning > issue in another way as a 2nd step. > > Signed-off-by: Amjad Ouled-Ameur <aouledameur@xxxxxxxxxxxx> > Reported-by: Jerome Brunet <jbrunet@xxxxxxxxxxxx> Acked-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> regards Philipp