RE: [PATCH v2 2/5] dt-bindings: usb: renesas,usb3-peri: Document HS and SS data bus

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Biju-san,

> From: Biju Das, Sent: Monday, August 24, 2020 8:55 PM
> 
> Hi Shimoda-San,
> 
> Thanks for the feedback.
> 
<snip>
> > > --- a/Documentation/devicetree/bindings/usb/renesas,usb3-peri.yaml
> > > +++ b/Documentation/devicetree/bindings/usb/renesas,usb3-peri.yaml
> > <snip>
> > > @@ -79,9 +92,20 @@ examples:
> > >          companion = <&xhci0>;
> > >          usb-role-switch;
> > >
> > > -        port {
> > > -            usb3_role_switch: endpoint {
> > > -                remote-endpoint = <&hd3ss3220_ep>;
> > > -            };
> > > -        };
> > > +    	ports {
> >
> > I think we should use spaces instead of tab here and below.
> 
> I have ran dt_binding_check on this file and it did n't complain.
> 
> First 5 character must be space, after that if you use tab, it won't complain.
> I am not sure is it the correct way or not?
> 
> Geert/Shimoda-San can you please comment.
> Based on your input, if needed I will send v3 with only spaces.

I don't know why dt_binding_check didn't complain though,
according to writing_schema.rst:
---
examples
  Optional. A list of one or more DTS hunks implementing the
  binding. Note: YAML doesn't allow leading tabs, so spaces must be used instead.
---
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/writing-schema.rst?h=v5.9-rc2#n71

Best regards,
Yoshihiro Shimoda





[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux