Hi Johan, Thanks for your reminding. I am adjusting patch according to the latest Linux Master branch. With best regards, Wang Sheng Long Siemens Ltd., China RC-CN DI FA R&D SW Tianyuan road No.99 611731 CHENGDU, China Mobil: +86 15281074996 mailto:shenglong.wang.ext@xxxxxxxxxxx -----Original Message----- From: Johan Hovold <johan@xxxxxxxxxx> Sent: Monday, August 24, 2020 5:10 PM To: Kiszka, Jan (CT RDA IOT SES-DE) <jan.kiszka@xxxxxxxxxxx> Cc: Sheng Long Wang <china_shenglong@xxxxxxx>; Wang, Sheng Long (EXT) (RC-CN DI FA R&D SW) <shenglong.wang.ext@xxxxxxxxxxx>; johan@xxxxxxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx Subject: Re: [PATCH v3] usb-serial:cp210x: add support to software flow control On Fri, Aug 21, 2020 at 07:32:58AM +0200, Jan Kiszka wrote: > On 20.08.20 09:52, Sheng Long Wang wrote: > > From: Wang Sheng Long <shenglong.wang.ext@xxxxxxxxxxx> > > > > When data is transmitted between two serial ports, the phenomenon of > > data loss often occurs. The two kinds of flow control commonly used > > in serial communication are hardware flow control and software flow > > control. > > > > In serial communication, If you only use RX/TX/GND Pins, you can't > > do hardware flow. So we often used software flow control and prevent > > data loss. The user sets the software flow control through the > > application program, and the application program sets the software > > flow control mode for the serial port chip through the driver. > > > > For the cp210 serial port chip, its driver lacks the software flow > > control setting code, so the user cannot set the software flow > > control function through the application program. This adds the > > missing software flow control. > > > > Signed-off-by: Wang Sheng Long <shenglong.wang.ext@xxxxxxxxxxx> > > > > Changes in v3: > > -fixed code style, It mainly adjusts the code style acccording to > > kernel specification. > > Patch does not apply. You forgot to rebase over latest tty/tty-next or > linux master. That should be the usb-next branch of the usb-serial tree: https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git/ or linux-next (or, currently, Linus's master branch). You can use "scripts/get_maintainer.sh --scm" to determine which tree to base your work against. Johan