On 21.8.2020 12.57, Peter Chen wrote: > >>> >>> Signed-off-by: Peter Chen <peter.chen@xxxxxxx> >>> --- >>> drivers/usb/host/xhci-plat.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/usb/host/xhci-plat.c >>> b/drivers/usb/host/xhci-plat.c index 14ff65a387e8..cfca6fc8947c 100644 >>> --- a/drivers/usb/host/xhci-plat.c >>> +++ b/drivers/usb/host/xhci-plat.c >>> @@ -287,7 +287,7 @@ static int xhci_plat_probe(struct platform_device *pdev) >>> *priv = *priv_match; >>> } >>> >>> - device_wakeup_enable(hcd->self.controller); >>> + device_set_wakeup_capable(&pdev->dev, true); >> >> All other patches seem pretty straight forward, but with this one I have to some >> more digging. >> I saw you had a discussion with Alan about this topic about a month ago, but I'm >> not sure if there was any conclusion about this. >> > > Alan suggested set power/wakeup as default enabled before, but it will cause the power domain of > this device (and parent) will not be off during the system suspend/resume since the power management > code thinks that the power should not be off if the device needs to respond the wakeup during > the system suspends. We have agreed to set power/wakeup as default disabled. > > https://www.spinics.net/lists/linux-usb/msg199316.html > > Peter > Ok, thanks, got it. -Mathias
