On Mon, Aug 17, 2020 at 06:50:20PM +0200, Greg Kroah-Hartman wrote: > On Mon, Aug 17, 2020 at 07:42:26PM +0300, Andy Shevchenko wrote: > > For better maintenance sort headers alphabetically. > > Maintenance of what? That's pointless churn. Of this driver. When adding a new header may bring a duplication. > > While at it, move asm/*.h to be included after linux/*.h. > > That's the only valid type of change, but why is a driver having asm/*.h > files included in the first place? Shouldn't that be fixed? I can't see how. fixmap.h is special header for early boot stage and there is no linux/* part to cover it (no need). The pci-direct.h is a specific arch-dependent way to access PCI configuration space without PCI core to be involved (also as above, to be used on early boot stages). That said, I simply move them and will preserve ordering as it's now. -- With Best Regards, Andy Shevchenko
