On Fri, Jul 10, 2009 at 12:35:34PM -0700, Elina Pasheva wrote: > On Thu, 2009-07-09 at 23:36 -0700, Oliver Neukum wrote: > > Am Freitag, 10. Juli 2009 02:56:02 schrieb Elina Pasheva: > > > +module_param(support_autopm, bool, S_IRUGO | S_IWUSR); > > > +MODULE_PARM_DESC(support_autopm, "Device auto suspend support"); > > > > You implemented it correctly, but I cannot understand why it is needed > > at all. If you don't want autosuspend don't enable it the generic way. > > Why a module parameter? > > > > Regards > > Oliver > > > > > > Hi Oliver, > > Thank you for your feedback. > In principal we do want sierra driver to support autopm but some of our > devices do not support auto suspend. Having a module parameter like > "support_autopm" is an easier way to control this instead of asking the > customer to recompile and re-install the driver. But shouldn't you do that on a per-device basis? What happens if I plug in 2 devices, and both need a different option here? And what would control setting that module option? It's much better to do things dynamically. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
