On Fri, Aug 14, 2020 at 06:25:04AM +0000, Peter Chen wrote: > Hi Alan, > > We may can't set the wakeup enabled as default value since it will > affect the parent's wakeup setting. See function: > dpm_propagate_wakeup_to_parent at drivers/base/power/main.c. > The parent's wakeup_path is set as true during the system > system routine, then the power domain for the parent will not be > off (See genpd_finish_suspend) after system suspend, it does not > meet design expectation. The expectation is the device's power > domain is only on if the device as wakeup source. > > Even with host-only use case, the thing is the same. If wakeup enabled > as default, the related power domain will be on during the system > suspend no matter the wakeup is really wanted. > > Do you agree I set the wakeup default value as disabled? Yes, I guess so. There doesn't seem to be any other way to handle this. What we really should have is a setting which means "Leave wakeup turned off unless it is enabled for a child device". Maybe something like that can be added in the future. Alan Stern
