> -----Original Message----- > From: Jun Li > Sent: Thursday, July 23, 2020 5:58 PM > To: Felipe Balbi <balbi@xxxxxxxxxx>; shawnguo@xxxxxxxxxx; robh+dt@xxxxxxxxxx > Cc: gregkh@xxxxxxxxxxxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx; > festevam@xxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx>; linux-usb@xxxxxxxxxxxxxxx; > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; Peter Chen > <peter.chen@xxxxxxx>; Anson Huang <anson.huang@xxxxxxx>; Peng Fan > <peng.fan@xxxxxxx>; Horia Geanta <horia.geanta@xxxxxxx> > Subject: RE: [PATCH v2 1/5] usb: dwc3: add platform data to dwc3 core device to > pass data > > > > > -----Original Message----- > > From: Felipe Balbi <balbif@xxxxxxxxx> On Behalf Of Felipe Balbi > > Sent: Thursday, July 23, 2020 5:22 PM > > To: Jun Li <jun.li@xxxxxxx>; shawnguo@xxxxxxxxxx; robh+dt@xxxxxxxxxx > > Cc: gregkh@xxxxxxxxxxxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx; > > kernel@xxxxxxxxxxxxxx; festevam@xxxxxxxxx; dl-linux-imx > > <linux-imx@xxxxxxx>; linux-usb@xxxxxxxxxxxxxxx; > > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; > > Peter Chen <peter.chen@xxxxxxx>; Anson Huang <anson.huang@xxxxxxx>; > > Peng Fan <peng.fan@xxxxxxx>; Horia Geanta <horia.geanta@xxxxxxx> > > Subject: Re: [PATCH v2 1/5] usb: dwc3: add platform data to dwc3 core > > device to pass data > > > > > > Hi, > > > > Li Jun <jun.li@xxxxxxx> writes: > > > In case dwc3 has SoC specific customizations, dwc3 glue driver can > > > base on compatible string and pass it via platform data to dwc3 core > > > driver; and pass xhci private data further to xhci-plat like quirks. > > > > > > Signed-off-by: Li Jun <jun.li@xxxxxxx> > > > --- > > > drivers/usb/dwc3/core.h | 5 +++++ > > > drivers/usb/dwc3/host.c | 9 +++++++++ > > > 2 files changed, 14 insertions(+) > > > > > > diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h index > > > 0b8ea8c..3146697 100644 > > > --- a/drivers/usb/dwc3/core.h > > > +++ b/drivers/usb/dwc3/core.h > > > @@ -29,6 +29,7 @@ > > > #include <linux/ulpi/interface.h> > > > > > > #include <linux/phy/phy.h> > > > +#include "../host/xhci-plat.h" > > > > > > #define DWC3_MSG_MAX 500 > > > > > > @@ -924,6 +925,10 @@ struct dwc3_scratchpad_array { > > > __le64 dma_adr[DWC3_MAX_HIBER_SCRATCHBUFS]; > > > }; > > > > > > +struct dwc3_platform_data { > > > + struct xhci_plat_priv *xhci_priv; > > > +}; > > > > why? We should rely on properties, no? > > My v1 patch was adding new property directly, considering Rob has objection on that > way if I understand correctly, also there is suggestion on use compatible string > to set quirks, I changed to add platform data to pass SoC level quirks, I think > this also can be used to extend other special handling for glue layer driver, so > should I go back to use properties? > Hope an agreement can be made on adding new properties/quirks. ' Hi Felipe, Could you please point me how I can move forward on this, thanks a lot. Li Jun > > Thanks > Li Jun > > > > > -- > > balbi