On Fri, 10 Jul 2009, Daniel Mack wrote:
> On Fri, Jul 10, 2009 at 11:36:20AM +0300, jouni wrote:
> > On Friday 10 July 2009 11:16:08 Daniel Mack wrote:
> > > On Fri, Jul 10, 2009 at 11:04:13AM +0300, jouni wrote:
> > > > I just tested this patch and it works for me.
> > >
> > > Thanks for testing! Could you provide the dmesg output?
>
> Ok thanks. Below is the patch with a changelog.
>
> Thanks everyone :)
>
> Daniel
Greg, it's worth noting that this patch fixes Bugzilla #13700. Hence
it needs to get into 2.6.30.stable as well as 2.6.31.
Alan Stern
> commit 87803165ad7727fbb1576294bff2d9d1e9b95827
> Author: Daniel Mack <daniel@xxxxxxxx>
> Date: Fri Jul 10 10:53:07 2009 +0200
>
> USB: fix LANGID=0 regression
>
> commit b7af0bb ("USB: allow malformed LANGID descriptors") broke support
> for devices without string descriptor support.
>
> Reporting string descriptors is optional to USB devices, and a device
> lets us know it can't deal with strings by responding to the LANGID
> request with a STALL token.
>
> The kernel handled that correctly before b7af0bb came in, but failed
> hard if the LANGID was reported but broken. More than that, if a device
> was not able to provide string descriptors, the LANGID was retrieved
> over and over again at each string read request.
>
> This patch changes the behaviour so that
>
> a) the LANGID is only queried once
> b) devices which can't handle string requests are not asked again
> c) devices with malformed LANGID values have a sane fallback to 0x0409
>
> Signed-off-by: Daniel Mack <daniel@xxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
