Looks good to me. Reviewed-by: JC Kuo <jckuo@xxxxxxxxxx> On 8/10/20 10:00 PM, Thierry Reding wrote: > On Sun, Aug 09, 2020 at 09:29:48AM +0200, Christophe JAILLET wrote: >> There is no need to use GFP_ATOMIC here. It is a probe function, no >> spinlock is taken. >> >> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx> >> --- >> drivers/usb/gadget/udc/tegra-xudc.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > Looks good to me. I can't think of any reason why this would have to be > an atomic allocation. Nagarjuna, please shout if this is really needed, > otherwise: > > Acked-by: Thierry Reding <treding@xxxxxxxxxx>