Re: [PATCH 1/6] USB: UDC: Expand device model API interface

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 07, 2020 at 10:21:53AM +0000, Peter Chen wrote:
>  
> > 
> > On Fri, Aug 07, 2020 at 05:41:46PM +0800, Peter Chen wrote:
> > > From: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> > >
> > > The routines used by the UDC core to interface with the kernel's
> > > device model, namely usb_add_gadget_udc(),
> > > usb_add_gadget_udc_release(), and usb_del_gadget_udc(), provide access
> > > to only a subset of the device model's full API.  They include
> > > functionality equivalent to device_register() and device_unregister()
> > > for gadgets, but they omit device_initialize(), device_add(),
> > > device_del(), get_device(), and put_device().
> > >
> > > This patch expands the UDC API by adding usb_initialize_gadget(),
> > > usb_add_gadget(), usb_del_gadget(), usb_get_gadget(), and
> > > usb_put_gadget() to fill in the gap.  It rewrites the existing
> > > routines to call the new ones.
> > >
> > > CC: Anton Vasilyev <vasilyev@xxxxxxxxx>
> > > CC: Evgeny Novikov <novikov@xxxxxxxxx>
> > > CC: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>
> > > Signed-off-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> > 
> > You can not forward on patches from someone else without also signing off on
> > them.
> > 
>  
> So, even without contribution for the patch, we also need to add signing off when
> submit?

Please read the DCO, you are submitting some else's work here, it is
passing through you, you need to add your s-o-b to it.  It's only been
this way since the very beginning :)

thanks,

greg k-h



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux