On Fri, Jul 31, 2020 at 02:20:58PM +0200, Christian Gromm wrote:
> This patch adds the USB driver source file most_usb.c and
> modifies the Makefile and Kconfig accordingly.
>
> Signed-off-by: Christian Gromm <christian.gromm@xxxxxxxxxxxxx>
> ---
> v2:
> Reported-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> - don't remove usb driver from staging area
> - don't touch staging/most/Kconfig
> - remove subdirectory for USB driver and put source file into
> drivers/most
> v3:
> - submitted fixes found during code audit to staging version
> first to be able to resend single patch that adds the driver
> v4:
> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>
> submitted patch set that fixes issues found during code audit
> to staging version first to be able to resend single patch that
> adds the driver. The patch series included:
>
> - use function sysfs_streq
> - add missing put_device calls
> - use correct error codes
> - replace code to calculate array index
> - don't use error path to exit function on success
> - move allocation of URB out of critical section
> - return 0 instead of variable
> - change return value of function drci_rd_reg
> - don't use expressions that might fail in a declaration
> - change order of function parameters
>
> v5:
> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>
> submitted patch set that fixes issues found during code audit
> to staging version first to be able to resend single patch that
> adds the driver. The patch series included:
>
> - init return value in default path of switch/case expression
>
> v6:
> Reported-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
>
> remove dependency to NET in Kconfig file
>
> v7:
> Reported-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
>
> created patch with 'git format-patch -M' to show that this is
> a move only.
>
> drivers/most/Kconfig | 11 +++++++++++
> drivers/most/Makefile | 2 ++
> drivers/{staging/most/usb/usb.c => most/most_usb.c} | 0
> drivers/staging/most/Kconfig | 2 --
> drivers/staging/most/usb/Kconfig | 13 -------------
> drivers/staging/most/usb/Makefile | 4 ----
> 6 files changed, 13 insertions(+), 19 deletions(-)
> rename drivers/{staging/most/usb/usb.c => most/most_usb.c} (100%)
> delete mode 100644 drivers/staging/most/usb/Kconfig
> delete mode 100644 drivers/staging/most/usb/Makefile
Thanks, this worked, now queued up!
greg k-h
