Hello Minas, On Sun, Jul 26, 2020 at 12:04 PM Minas Harutyunyan <Minas.Harutyunyan@xxxxxxxxxxxx> wrote: [...] > Kernel test robot found issue: > >> warning: unused label 'error_debugfs' [-Wunused-label] > error_debugfs: > ^~~~~~~~~~~~~~ > 1 warning generated. > > So, 'error_debugfs:' label should be under #if/#endif: > > #if IS_ENABLED(CONFIG_USB_DWC2_PERIPHERAL) || \ > IS_ENABLED(CONFIG_USB_DWC2_DUAL_ROLE) > error_debugfs: > #endif /* CONFIG_USB_DWC2_PERIPHERAL || CONFIG_USB_DWC2_DUAL_ROLE */ > > Or you have other suggestion? unfortunately I have no better idea > Could you please fix this issue and submit new version of patch. I'm going to cover everything I add inside the same #if (not just the error label). if any additional label is added (above) in the future then the code that I'm adding must not be executed when that #if evaluates to false v3 is coming in the next few minutes. Best regards, Martin
