Re: [balbi-usb:testing/next 1/39] drivers/usb/dwc2/drd.c:80:36: error: 'struct dwc2_hsotg' has no member named 'test_mode'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7/24/20 12:48 PM, Amelie DELAUNAY wrote:
On 7/24/20 9:59 AM, Amelie DELAUNAY wrote:
Hi Felipe,

On 7/24/20 9:51 AM, Felipe Balbi wrote:
kernel test robot <lkp@xxxxxxxxx> writes:

tree: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git testing/next
head:   74dbc49b08d37ed9d4fd440d8896626733f80564
commit: bc0f0d4a5853e32ba97a0318f774570428fc5634 [1/39] usb: dwc2: override PHY input signals with usb role switch support
config: nios2-randconfig-r002-20200724 (attached as .config)
compiler: nios2-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
         chmod +x ~/bin/make.cross
         git checkout bc0f0d4a5853e32ba97a0318f774570428fc5634
         # save the attached .config to linux build tree
         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nios2

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

    drivers/usb/dwc2/drd.c: In function 'dwc2_drd_role_sw_set':
drivers/usb/dwc2/drd.c:80:36: error: 'struct dwc2_hsotg' has no member named 'test_mode'
       80 |  if (role == USB_ROLE_NONE && hsotg->test_mode) {

weird, this compiled just fine here with allmodconfig on AArch64.

/me goes check. Oh, I see what's happening, hsotg->test_mode is only
compiled on Peripheral-only and Dual-role builds. I'm assuming this was
a Host-only build. Then the problem triggers because drd.o is
unconditionally added to the binary.

dwc2-y                    := core.o core_intr.o platform.o drd.o

Is this an old problem or was it triggered by $subject?


I sent a mail yesterday (https://lkml.org/lkml/2020/7/23/114) to warn about the upcoming v2.

This build issue is fixed in the v2 (https://lore.kernel.org/patchwork/project/lkml/list/?series=454729).


Build issue fixed in v3 instead:
https://lore.kernel.org/patchwork/project/lkml/list/?series=454936


Drop the previous "Add USB role switch support to DWC2" patchset. I'm preparing a new patchset with fixes to address this build issue and remarks reported by Martin Blumenstingl.

Regards,
Amelie




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux