[usb:usb-testing 187/195] drivers/usb/host/xhci-dbgcap.c:410:1: warning: no previous prototype for 'xhci_dbc_ring_alloc'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
head:   9a360a7cae11461ccd933a9ea366b0dcb3afadb0
commit: ac286428c69fb3dc2924ce0ad5a11b5577b2f5da [187/195] xhci: dbc: don't use generic xhci ring allocation functions for dbc.
config: i386-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-14) 9.3.0
reproduce (this is a W=1 build):
        git checkout ac286428c69fb3dc2924ce0ad5a11b5577b2f5da
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

>> drivers/usb/host/xhci-dbgcap.c:410:1: warning: no previous prototype for 'xhci_dbc_ring_alloc' [-Wmissing-prototypes]
     410 | xhci_dbc_ring_alloc(struct device *dev, enum xhci_ring_type type, gfp_t flags)
         | ^~~~~~~~~~~~~~~~~~~
   drivers/usb/host/xhci-dbgcap.c: In function 'xhci_dbc_mem_cleanup':
   drivers/usb/host/xhci-dbgcap.c:530:18: warning: unused variable 'dev' [-Wunused-variable]
     530 |  struct device  *dev = xhci_to_hcd(xhci)->self.controller;
         |                  ^~~

vim +/xhci_dbc_ring_alloc +410 drivers/usb/host/xhci-dbgcap.c

   408	
   409	struct xhci_ring *
 > 410	xhci_dbc_ring_alloc(struct device *dev, enum xhci_ring_type type, gfp_t flags)
   411	{
   412		struct xhci_ring *ring;
   413		struct xhci_segment *seg;
   414		dma_addr_t dma;
   415	
   416		ring = kzalloc(sizeof(*ring), flags);
   417		if (!ring)
   418			return NULL;
   419	
   420		ring->num_segs = 1;
   421		ring->type = type;
   422	
   423		seg = kzalloc(sizeof(*seg), flags);
   424		if (!seg)
   425			goto seg_fail;
   426	
   427		ring->first_seg = seg;
   428		ring->last_seg = seg;
   429		seg->next = seg;
   430	
   431		seg->trbs = dma_alloc_coherent(dev, TRB_SEGMENT_SIZE, &dma, flags);
   432		if (!seg->trbs)
   433			goto dma_fail;
   434	
   435		seg->dma = dma;
   436	
   437		/* Only event ring does not use link TRB */
   438		if (type != TYPE_EVENT) {
   439			union xhci_trb *trb = &seg->trbs[TRBS_PER_SEGMENT - 1];
   440	
   441			trb->link.segment_ptr = cpu_to_le64(dma);
   442			trb->link.control = cpu_to_le32(LINK_TOGGLE | TRB_TYPE(TRB_LINK));
   443		}
   444		INIT_LIST_HEAD(&ring->td_list);
   445		xhci_initialize_ring_info(ring, 1);
   446		return ring;
   447	dma_fail:
   448		kfree(seg);
   449	seg_fail:
   450		kfree(ring);
   451		return NULL;
   452	}
   453	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux