Hi, Lee Jones <lee.jones@xxxxxxxxxx> writes: > On Tue, 21 Jul 2020, Felipe Balbi wrote: > >> Minas Harutyunyan <Minas.Harutyunyan@xxxxxxxxxxxx> writes: >> >> > Hi Felipe, >> > >> > On 7/21/2020 1:43 PM, Felipe Balbi wrote: >> >> Minas Harutyunyan <Minas.Harutyunyan@xxxxxxxxxxxx> writes: >> >> >> >>> On 7/15/2020 1:32 PM, Lee Jones wrote: >> >>>> The value obtained from GINTSTS2 should be masked with the GINTMSK2 >> >>>> value. Looks like this has been broken since >> >>>> dwc2_gadget_wkup_alert_handler() was added back in 2018. >> >>>> >> >>>> Also fixes the following W=1 warning: >> >>>> >> >>>> drivers/usb/dwc2/gadget.c: In function ‘dwc2_gadget_wkup_alert_handler’: >> >>>> drivers/usb/dwc2/gadget.c:259:6: warning: variable ‘gintmsk2’ set but not used [-Wunused-but-set-variable] >> >>>> 259 | u32 gintmsk2; >> >>>> | ^~~~~~~~ >> >>>> >> >>>> Cc: Minas Harutyunyan <hminas@xxxxxxxxxxxx> >> >>>> Cc: Ben Dooks <ben@xxxxxxxxxxxx> >> >>>> Fixes: 187c5298a1229 ("usb: dwc2: gadget: Add handler for WkupAlert interrupt") >> >>>> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx> >> >>> >> >>> Acked-by: Minas Harutyunyan <hminas@xxxxxxxxxxxx> >> >> >> >> Should I apply the entire series or only 1/8? >> >> >> > In this series only 2 patches are related to dwc2, which I'm already Acked: >> > >> > [PATCH v2 1/8] usb: dwc2: gadget: Make use of GINTMSK2 >> > [PATCH v2 2/8] usb: dwc2: gadget: Avoid pointless read of EP control >> > register >> > >> > I can't acked other patches from this series, because they are not >> > related to dwc2. >> >> heh, I saw that after sending the email, sorry :-) > > Also, all patches are already in -next, courtesy of Greg. Cool, I'll rebase on top of Greg's branch -- balbi
Attachment:
signature.asc
Description: PGP signature