On Thu, Jul 16, 2020 at 11:05:03AM +0200, Greg Kroah-Hartman wrote:
> On Thu, Jul 16, 2020 at 10:50:55AM +0200, Johan Hovold wrote:
> > The set-led command is eight bytes long and starts with a command byte
> > followed by six bytes of RGB data and ends with a byte encoding a
> > frequency (see iuu_led() and iuu_rgbf_fill_buffer()).
> >
> > The led activity helpers had a few long-standing bugs which corrupted
> > the command packets by inserting a second command byte and thereby
> > offsetting the RGB data and dropping the frequency in non-xmas mode.
> >
> > In xmas mode, a related off-by-one error left the frequency field
> > uninitialised.
> >
> > Fixes: 60a8fc017103 ("USB: add iuu_phoenix driver")
> > Reported-by: George Spelvin <lkml@xxxxxxx>
> > Signed-off-by: Johan Hovold <johan@xxxxxxxxxx>
>
> Reviewed-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
Thanks for reviewing. Now applied for -next.
Johan
