Hi Greg, > -----Original Message----- > From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > Sent: Thursday, July 16, 2020 12:05 AM > To: Mani, Rajmohan <rajmohan.mani@xxxxxxxxx> > Cc: Darren Hart <dvhart@xxxxxxxxxxxxx>; Andy Shevchenko > <andy@xxxxxxxxxxxxx>; Mika Westerberg > <mika.westerberg@xxxxxxxxxxxxxxx>; Dmitry Torokhov > <dmitry.torokhov@xxxxxxxxx>; Lee Jones <lee.jones@xxxxxxxxxx>; Ayman > Bagabas <ayman.bagabas@xxxxxxxxx>; Masahiro Yamada > <masahiroy@xxxxxxxxxx>; Joseph, Jithu <jithu.joseph@xxxxxxxxx>; Blaž > Hrastnik <blaz@xxxxxxx>; Srinivas Pandruvada > <srinivas.pandruvada@xxxxxxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx; > platform-driver-x86@xxxxxxxxxxxxxxx; Heikki Krogerus > <heikki.krogerus@xxxxxxxxxxxxxxx>; linux-usb@xxxxxxxxxxxxxxx; > pmalani@xxxxxxxxxxxx; bleung@xxxxxxxxxxxx > Subject: Re: [PATCH 2/2] usb: typec: intel_pmc_mux: Check the port status > before connect > > On Wed, Jul 15, 2020 at 05:33:10PM -0700, Rajmohan Mani wrote: > > From: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx> > > > > The PMC microcontroller that we use for configuration, does not supply > > any status information back. For port status we need to talk to > > another controller on the board called IOM (I/O manager). > > > > By checking the port status before configuring the muxes, we can make > > sure that we do not reconfigure the port after bootup when the system > > firmware (for example BIOS) has already configured it. > > > > Using the status information also to check if DisplayPort HPD is still > > asserted when the cable plug is disconnected, and clearing it if it > > is. > > > > Signed-off-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx> > > You can't just forward on patches from others without also adding your > signed-off-by to them, right? > Sorry I missed this. > Please fix up this series and try again. > Ack. Will fix this with v2. > thanks, > > greg k-h