Re: [PATCH] hwmon: add fan/pwm driver for corsair h100i platinum

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 15 Jul 2020 at 16:47, Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
>
> On Wed, Jul 15, 2020 at 01:18:58PM +0200, jaap aarts wrote:
> > On Wed, 15 Jul 2020 at 05:07, Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
> > >
> > > On Tue, Jul 14, 2020 at 12:03:38PM +0200, jaap aarts wrote:
> > > > Adds fan/pwm support for H1000i platinum.
> > > > Custom temp/fan curves are not supported, however
> > > > the presets found in the proprietary drivers are avaiable.
> > > >
> > > > Signed-off-by: Jaap Aarts <jaap.aarts1@xxxxxxxxx>
> > >
> > > +Marius Zachmann for input.
> > >
> > > Questions:
> > > - Does this really have to be a different driver or can it be merged into
> > >   the corsair-cpro driver ?
> > I cannot find this driver at the moment, the only corsair driver I can find
> > is the HID driver. As far as I know all asetek gen 6 products use the same
> > interface. Out of curiosity I contacted asetek to confirm, but other userland
> > drivers have used the same code for all products of previous generations.
> > > - What about HID vs. USB driver ?
> > This is not really a HID. I asked in the kernel newbies mailing list and
> > I was told HWMON is probably the right place. Most of the code is
> > related to HWMON so this seems to be the right place to me as well.
>
> Question is if this identifies itself as HID device. If it does,
> it would either have to be blacklisted in the HID core, or it would
> have to be implemented as hid driver. The latter would be preferred,
> since otherwise a userspace application accessing it directly would
> no longer work. Either case, the driver can and should still reside
> in hwmon; that was not the question.
Thanks for the clarification, lsusb lists bInterfaceClass as 255 or
"Vendor Specific Class", so not as a HID.
>
> Thanks,
> Guenter



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux