On Wed, Jul 15, 2020 at 02:17:37PM +0200, Marius Zachmann wrote: > On 15.07.20 at 05:07:40 CEST, Guenter Roeck wrote > > On Tue, Jul 14, 2020 at 12:03:38PM +0200, jaap aarts wrote: > > > Adds fan/pwm support for H1000i platinum. > > > Custom temp/fan curves are not supported, however > > > the presets found in the proprietary drivers are avaiable. > > > > > > Signed-off-by: Jaap Aarts <jaap.aarts1@xxxxxxxxx> > > > > +Marius Zachmann for input. > > > > Questions: > > - Does this really have to be a different driver or can it be merged into > > the corsair-cpro driver ? > > > > From what I can see the protocol has quite a few differences. > A merged driver would need to implement functions like e.g. set_pwm for > each device seperately. Also error handling and buffer sizes would be > seperate for each device. > If there were more usb/hid drivers in hwmon it maybe could make sense > to have an additional abstraction layer, but for now I do not see > anything which could be gained by this. > Ok. Thanks, Guenter
