On Mon 6 Jul 2009 00:56, Mike Frysinger pondered: > On Mon, Jul 6, 2009 at 00:38, Robin Getz wrote: > > It appears that the usb serial doesn't handle breaks like serial_core > > does. (I don't see any support for SAK in usb_serial either?) > > > > Maybe _that_ is the real problem that Jason is trying to work around??? > > perhaps, but what Jason proposed originally sounds pretty sane. Which is why Greg added it to the USB tree, and it is in 2.6.31-rc2 :) http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=568d422e9cf52b7b26d2e026ae1617971f62b560 > if i > enable sysrq support on my desktop, i dont want some development board > being able to send a sysrq request back over my serial port and > rebooting my desktop. Fixing something in the wrong place -- while noble -- is still wrong :) However -- with the way that usb serial is structured - I didn't see a better place right now either. The point being that is would be nice to make usb serial look more like other serial devices - so they can share mode code - and things like this (that have been in serial_core.h since -pre-git history (2005) wouldn't just be getting added to the usb serial infrastructure now)... -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
