On Tue, 14 Jul 2020 at 19:31, Guenter Roeck <linux@xxxxxxxxxxxx> wrote: > > On 7/14/20 3:03 AM, jaap aarts wrote: > > On Tue, 14 Jul 2020 at 06:59, Guenter Roeck <linux@xxxxxxxxxxxx> wrote: > >> > >> On 7/13/20 12:32 PM, jaap aarts wrote: > >>> Signed-off-by: Jaap Aarts <jaap.aarts1@xxxxxxxxxxx> > >> > >> I am not going to review code which is later changed in the > >> same patch series. Please combine all patches into one. > >> > >> Guenter > > > > Thanks for the feedback, most guides state you should > > split up your changes into smaller patches if they get very big. > > Yes, but not if the later patches change the initial ones. this > is not the case here. Your first patch doesn't even register a > hwmon device. The last two patches change previous patches, meaning > I would just waste my time reviewing patches 1..4. Worse, all those > style issues fixed in the last patch would create so much noise that > I might miss real issues. Ok thanks, for future patches I will keep this in mind. If this driver gets in I will be adding other features. I will keep this in mind when submitting those. I send it as one patch, it's quite big, I will split my patches more appropriately next time. > A split would have been fine if the first patch introduced working > code, then subsequent patches built on it without replacing previously > introduced code. > > Guenter > > > Maybe I misunderstood the intent of that? > > Anyways I combined all patches, fixed my signoff line, added > > a changelog and fixed my subject line. > > > > Thanks, > > > > Jaap Aarts > > >
