Hi Manivannan, On Tue, Jul 14, 2020 at 12:37 PM Manivannan Sadhasivam <mani@xxxxxxxxxx> wrote: > > Hi, > > On Tue, Jul 14, 2020 at 12:08:51PM +0200, Johan Hovold wrote: > > On Fri, Jul 10, 2020 at 12:21:26AM +0200, Angelo Dureghello wrote: > > > From some researches, this driver is available from the IC > > > constructor site, but for older kernel versions. From there, decided > > > to add a much simplier mainline version, written from scratch. > > > > Do you have a pointer to the vendor sources for reference? > > > > > This initial simple version is implemented without any flow control, > > > tested mainly at 115200, but all standard baud rates are supported > > > and applied as per serial terminal settings. > > > > > > Signed-off-by: Angelo Dureghello <angelo.dureghello@xxxxxxxxxxx> > > Just curious, how are you accessing this chip? I mean any breakout board > or integrated in any custom board design. > well, generally i design boards too, so i select the chips as i like them, but this time the chip is mounted on a custom design i work in. > > > Reported-by: kernel test robot <lkp@xxxxxxxxx> > > > > No need for a reported-by if the robot catches issues during review. > > Just mention it in the changelog as you already did below. > > > > > --- > > > Changes for v2: > > > - fix test robot warning, PARITY_ defines renamed > > > --- > > > drivers/usb/serial/Kconfig | 9 + > > > drivers/usb/serial/Makefile | 1 + > > > drivers/usb/serial/xr21v1412.c | 361 +++++++++++++++++++++++++++++++++ > > > 3 files changed, 371 insertions(+) > > > create mode 100644 drivers/usb/serial/xr21v1412.c > > > > Thanks for the submitting this. > > > > There was another driver for this device posted recently, and which > > appears to have more features: > > > > https://lore.kernel.org/r/20200607162350.21297-2-mani@xxxxxxxxxx > > > > Would you mind taking a look and see if that one would work for you? > > > > I had some comments on the latest version that needs to be addressed, > > but I'm assuming Manivannan is working on a v5? > > > > Yes! This driver is being worked on in my limited spare time. So I'm a bit > late to reiterate the patchset but planning to send v5 around this weekend. > Ok, as said, i don't want to overlap, wasn't aware of the job in progress. Going standby on this. Good luck. > Thanks, > Mani > > > Johan -- Angelo Dureghello Timesys e. angelo.dureghello@xxxxxxxxxxx
