On Thu, Jul 9, 2020 at 9:38 AM Felipe Balbi <balbi@xxxxxxxxxx> wrote:
>
> Ruslan Bilovol <ruslan.bilovol@xxxxxxxxx> writes:
>
> > As per UAC2 spec (ch. 4.7.2), wTotalLength of AC Interface
> > Header Descriptor "includes the combined length of this
> > descriptor header and all Clock Source, Unit and Terminal
> > descriptors."
> >
> > Thus add its size to its wTotalLength.
> >
> > Also after recent changes wTotalLength is calculated
> > dynamically, update static definition of uac2_ac_header_descriptor
> > accordingly
> >
> > Signed-off-by: Ruslan Bilovol <ruslan.bilovol@xxxxxxxxx>
>
> Missing a Fixes tag here.
The issue is present since this driver introduction in 2012 in the
commit 132fcb460839 "usb: gadget: Add Audio Class 2.0 Driver",
but in older version of the driver it should be fixed in the
uac2_ac_header_descriptor structure initialization
Should I resend this patch or you'll add this tag to the commit message
by yourself:
Fixes: 132fcb460839 ("usb: gadget: Add Audio Class 2.0 Driver")
Thanks,
Ruslan
