On Tue, Jul 07, 2020 at 02:06:26PM -0600, Shuah Khan wrote: > On 7/7/20 1:52 PM, Gustavo A. R. Silva wrote: > > Replace the existing /* fall through */ comments and its variants with > > the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary > > fall-through markings when it is the case. > > > > [1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through > > > > Is fallthrough syntax supported on our min gcc version? > The __attribute__((__fallthrough__)) has been supported since GCC 7.1 and it should be no problem for early versions because fallthrough is a macro that also expands to: do {} while (0) /* fallthrough */ > Does checkpatch or coccicheck catch these cases? > checkpatch does: https://git.kernel.org/linus/f36d3eb89a43047d3eba222a8132585da25cebfd > The patch looks good. > > Acked-by: Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx> > Thanks -- Gustavo
