Thanks for your suggestin Greg KH I think there is not need fix tags. I will resend. thanks, Zhang Qiang ________________________________________ 发件人: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> 发送时间: 2020年7月6日 18:31 收件人: Zhang, Qiang 抄送: balbi@xxxxxxxxxx; colin.king@xxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx 主题: Re: [PATCH v2] usb: gadget: function: fix missing spinlock in f_uac1_legacy On Sun, Jul 05, 2020 at 02:16:16PM +0800, qiang.zhang@xxxxxxxxxxxxx wrote: > From: Zhang Qiang <qiang.zhang@xxxxxxxxxxxxx> > > Add a missing spinlock protection to the add operation of the "audio->play_queue" > in "f_audio_out_ep_complete" function. That says _what_ you did, but not _why_ you did that. Why is a lock needed here? What does this protect? What kernel commit does this "fix"? Put that in the "Fixes:" line, and probably you need a "cc: stable" in that area too, right? thanks, greg k-h
