On Mon, Jul 6, 2020, at 13:49, Greg KH wrote: > > -The overall architecture of the API is about the same as the one above, > > -only the events are delivered in binary format. Each event is sent in > > -the following structure (its name is made up, so that we can refer to it):: [snip] > > +The overall architecture of the API is about the same as the one above, only the > > Why change that line? The original text says that the structure had a made up name — since there was no exposed structures to match. Now there is, it's no longer made up. > > > +events are delivered in binary format. The structures and constants are defined > > +in linux/usb/mon.h. > > Not your new uapi file location? That is the new uapi header — that'd be the location on the installed system, updated with the location within the repository instead. > __u64, right? Same for the rest of this file... Ack. > Why drop this? If you want to clean up the documentation, wonderful, > but again, don't do that in the same patch. Okay split that one line change to a separate change. I really should try to sit down and improve the docs overall, but that's a much bigger undertaking. > is size_t a value we can pass across user/kernel boundry? Are you sure > this isn't __kernel_size_t? No I'm not sure and I was pondering myself. I'll trust your instinct because you know this much better than me. But… I'm not sure how to use that from an uapi header? The __kernel_size_t does not appear to be defined by including linux/types.h. There's only three users of it in include/uapi/ and the only one that does not appear to re-define it as a typedef is include/uapi/linux/uio.h, but using the same include doesn't seem to work for me. So I expect I'll need a v3 for this one ;)
