Re: [PATCH v3 3/4] usb: dwc3: Add device property sgl-trb-cache-size-quirk

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

Tejas Joglekar <Tejas.Joglekar@xxxxxxxxxxxx> writes:
>> @@ -95,6 +95,10 @@ int dwc3_host_init(struct dwc3 *dwc)
>>  	if (dwc->usb2_lpm_disable)
>>  		props[prop_idx++] = PROPERTY_ENTRY_BOOL("usb2-lpm-disable");
>>  
>> +	if (dwc->sgl_trb_cache_size_quirk)
>> +		props[prop_idx++] =
>> +			PROPERTY_ENTRY_BOOL("sgl-trb-cache-size-quirk");
>> +
>>  	/**
>>  	 * WORKAROUND: dwc3 revisions <=3.00a have a limitation
>>  	 * where Port Disable command doesn't work.
>> 
> Does this implementation looks good to you? Rob has some concerned over the DT entries,
> you suggested using compatible string with this quirk addition.
> Can you please brief about how you would like to have this quirk implemented?
> I can send the updated patch. My patch series is pending for merge just because of the
> DT and quirk issue. Can you please help?

Yeah, you need to get into an agreement with Rob :-) I don't mind having
extra DT flags for things which can't be detected in runtime, Rob
disagrees.

-- 
balbi

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux