On Fri, Jul 03, 2020 at 01:35:34AM -0700, Chris Dickens wrote: > Currently Microsoft OS Feature Descriptors are handled using a > separately allocated USB request, however everything about this USB > request is identical to the USB request used for all other control > responses. Simplify the code by removing this separate USB request and > using the same USB request as all other control responses. > > While at it, simplify the composite_ep0_queue() function by removing the > req and gfp_flags arguments. The former is no longer necessary with a > single USB request and the latter is always GFP_ATOMIC. > > Signed-off-by: Chris Dickens <christopher.a.dickens@xxxxxxxxx> > --- > drivers/usb/gadget/composite.c | 69 +++++----------------------------- > drivers/usb/gadget/configfs.c | 11 ------ > include/linux/usb/composite.h | 9 ----- > 3 files changed, 9 insertions(+), 80 deletions(-) Did you confirm by testing that this actually works with a real device that wants to talk to Windows with those feature descriptors? thanks, greg k-h
